DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=date:from:to:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent;
        b=Hor2IyHILwdL+a/k5jo3L5ryEEtSJ1PRlysIkLsaZD6eNHEhasZkH5Ck1LmoTUpHq9vfVYFGXJK5/7I8jwcyMnVdtP3mQ7NwU0hg3YqJJ0sTtGxJZuZOL7g+Ph5OTZnuba4w1wS5kLMvA/jbQWdayDKAl2ZXi7baX8MfYtA5pvY=
Date: Wed, 2 Apr 2008 10:50:47 +0400
From: Tomash Brechko <tomash.brechko@gmail.com>
To: talk@openhack.ru
Subject: Re: patch to makefiles
Message-ID: <20080402065047.GA3138@moonlight.home>
References: <list-86164330@mx.softsearch.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <list-86164330@mx.softsearch.ru>
User-Agent: Mutt/1.5.16 (2007-06-09)

Hello Vladimir,

And thanks for the patch.  I have a few questions to ask though.


On Wed, Apr 02, 2008 at 08:08:52 +0400, Vladimir Timofeev wrote:
> 1. optionify optimization flags so by default they sets same as perl
> itself. This, for example, allow freebsd's ports compile module with
> default system settings. For old flags: perl Makefile.PL OPTIMIZE='-g
> -O3'

I agree that adding explicit OPTIMIZE was a bad idea.  I wanted to
enforce -O3 to squeeze the last drop of performance, but this way one
may miss some vital flag for the current Perl installation.  So I
removed OPTIMIZE from the makefiles.  I also added clean => target
from your patch for generated files.


> 2. resolve first item in TODO (it not installed libclient.a at all),
> files after install (on freebsd):

The first TODO item reads

  - Improve make files: libclient.a should not be installed (does it
    now?).

I guess your patch does the opposite.  I.e. I do _not_ want
libclient.a to be installed, and I'm not quite sure how to control
this.  You report that it wasn't installed on FreeBSD, which I think
is good, but it is installed on Linux (at least on Fedora 8).  So, do
you know how to disable the installation of this library?  libclient.a
is ment to be internal.  Or are there any good reasons to install it?


-- 
   Tomash Brechko